Allow cgi strategy for html and graphs #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now it just sets the option in munin.conf. It is still missing the apache/nginx part of the config to enable the cgi-scripts.
For apache2 as server, this configures apache2 to generate html and graphics by cgi.
A bit simplier then before, hopefully better then before. Creating html and graphs from cgi.
|
@kampfschlaefer - This looks good. Can you please write a spec that proves it works as intended? I want to require this for all pull requests from now on. Thanks! |
|
Well, to prove that it works, one would have to start a machine in test-kitchen and run it for at least 10 minutes and then check that a) a http-request returns a valid page with images and b) /var/www/munin and/or /var/cache/munin/www stay empty as all html and png-graphs should be dynamic... |
|
I think this can also be tested in Chefspec. When the graph strategy is specified as cgi then verify the config additions are written. If it's not, verify that they are not written. |
|
I really want to get this in. Since you are busy I am going to write some tests for this. |
GitBytes
added a commit
to EMSL-MSC/munin
that referenced
this pull request
Apr 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activate cgi-generation of graphs (and html).
Instead of generating html and pngs all day and night long, it might be easier if that is just generated when someone is looking at it. (To solve the question: if a graph is generated but no one is there to look at it, is the graph really generated?)
So far I only used that together with apache.