Skip to content

Commit

Permalink
sort volumes first on whether they have labels and secondly on name
Browse files Browse the repository at this point in the history
  • Loading branch information
jesseduffield committed Oct 10, 2022
1 parent 0e0997d commit ec8dfba
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions pkg/commands/volume.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,16 @@ func (c *DockerCommand) RefreshVolumes() error {

ownVolumes := make([]*Volume, len(volumes))

// we're sorting these volumes based on whether they have labels defined,
// because those are the ones you typically care about.
// Within that, we also sort them alphabetically
sort.Slice(volumes, func(i, j int) bool {
if len(volumes[i].Labels) == 0 && len(volumes[j].Labels) > 0 {
return false
}
if len(volumes[i].Labels) > 0 && len(volumes[j].Labels) == 0 {
return true
}
return volumes[i].Name < volumes[j].Name
})

Expand Down

0 comments on commit ec8dfba

Please sign in to comment.