Update colour docs #546
Open
Update colour docs #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems you have another commit regarding the handling of ssh in your PR is that on purpose ? |
This brings the docs into line with the lazygit docs.
unikitty37
force-pushed
the
update-colour-docs
branch
from
5d9c60b to
5ce4931
Compare
Not 100% sure what happened there but I've rebased against master and force-pushed, and now the PR just contains the right commit. Thanks for spotting that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with #543 — the default colour still isn't readable, but letting people know they can use hex values greatly helps work around that :)
This PR updates the docs for colours to be the same as those for lazygit (except I've retained the entry for
default, which lazygit doesn't mention).Specifically, this indicates that hex colours can be used, which I didn't know until I configured lazygit and realised they would work here too.