Use correct executable name depending on OS #4269 #4273
+12
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use correct executable name depending on OS.
When unzipping the new version, we were always extracting
lazygit
. On Windows, the executable is namedlazygit.exe
. This PR fixes that issue.go generate ./...
)I'm not really sure how to test this (and as far as I can tell there are no integration tests for this feature yet). When attempting to use the feature from a version started using
go run main.go
it fails when trying to replace the current executable. I'm unsure whether this is due to somethinggo run
does, or whether that is Windows specific behavior. If I remember correctly, on Windows you can't replace the current executable, so perhaps that needs dedicated support on Windows.Fixes #4269