Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate deprecated AllBranchesLogCmd to AllBranchesLogCmds #4345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChrisMcD1
Copy link
Contributor

  • PR Description

Fixes #3961

Solves this by migrating allBranchesLogCmd into the preferred allBranchesLogCmds. This would be breaking behavior if somebody was relying on the behavior that is reported as a bug in #3961. If they did not specify a allBranchesLogCmd element, and added some additional allBranchesLogCmds elements, and wanted a full list. Such a behavior was never documented, and relying on a deprecated element seems like user error, so I'm not very worried about that. I would assume most people are like the one in the issue, where they assumed that they should put all of the items they want to cycle through in the allBranchesLogCmds, if they defined it.

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@ChrisMcD1 ChrisMcD1 marked this pull request as ready for review February 28, 2025 22:31
@ChrisMcD1 ChrisMcD1 force-pushed the 3961-all-branches-log branch from 1ce80ef to aefa6e5 Compare February 28, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allBranchesLogCmds always includes default log command
1 participant