Migrate deprecated AllBranchesLogCmd to AllBranchesLogCmds #4345
+150
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3961
Solves this by migrating
allBranchesLogCmd
into the preferredallBranchesLogCmds
. This would be breaking behavior if somebody was relying on the behavior that is reported as a bug in #3961. If they did not specify aallBranchesLogCmd
element, and added some additionalallBranchesLogCmds
elements, and wanted a full list. Such a behavior was never documented, and relying on a deprecated element seems like user error, so I'm not very worried about that. I would assume most people are like the one in the issue, where they assumed that they should put all of the items they want to cycle through in theallBranchesLogCmds
, if they defined it.go generate ./...
)