[jest-resolve] Add support for packageFilter for custom resolvers#10393
Merged
SimenB merged 9 commits intojestjs:masterfrom Aug 12, 2020
Merged
[jest-resolve] Add support for packageFilter for custom resolvers#10393SimenB merged 9 commits intojestjs:masterfrom
packageFilter for custom resolvers#10393SimenB merged 9 commits intojestjs:masterfrom
Conversation
…t into add/support-for-packageFilter
SimenB
requested changes
Aug 11, 2020
Member
SimenB
left a comment
There was a problem hiding this comment.
Thanks!
This needs a test and an example in the docs for how this would be used to check the module prop
scinos
commented
Aug 11, 2020
| }; | ||
| }); | ||
|
|
||
| const mockResolveSync = < |
Contributor
Author
There was a problem hiding this comment.
Full disclosure: I've never used Jest+TS, I don't know if there is a better way of doing this.
SimenB
reviewed
Aug 12, 2020
SimenB
reviewed
Aug 12, 2020
Member
This was referenced Dec 17, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forwards option
packageFiltertoresolve. This is useful in case a custom resolver wants to use it. The best example is #2702 (in particular, #2702 (comment))Fixes #2702
Test plan
Write a custom resolver like
Then, in any jest test, when importing package
X, it will try to load it from the fieldmodulefirst, with fallback tomainifmoduledoesn't exist.