Update to nightly-2019-03-29

[nicholastmosher]

Hey there, following up on #15, I tried updating to the latest nightly and was mostly successful, with some minor hiccups. I was able to run the build-src.sh script and interactively apply each patch it gave to me, but at the end of it all it still failed to build, giving the Unknown compiler version, upgrade core_io? message. It also seemed to me like it didn't give me a whole year's worth of nighties to patch, so I'm wondering if it stopped early for some reason? Here's the output from running the build-src command:

$ commit-db list-valid nightly | GIT_DIR=/home/nick/Documents/rust/.git ./build-src.sh
==> Patching 02c1862fb55c6ae4198038b1b317bcdd06e395d1
==> Patching 031f9b15df3df5da19b64a1f824463053898d021
==> Patching 06da917b015a2eceac0e3cca22f9660edef25178
==> Patching 075e16b2615ed16db9225bb28048cb334324e071
==> Patching 0b9c686b479ce337581ba9773481ada8dd8f91d6
==> Patching 0ca9967af75f7a279dcf4921f119b2602b41dd71
==> Patching 0ceeb1be31b52837e270a3349f9c62087ff11985
==> Patching 0f02309e4b0ea05ee905205278fb6d131341c41f
==> Patching 117cbb879e6ef498ea04e08bd80688bf2fc4a183
==> Patching 161c541afdd18423940e97c7a02b517b1f6d61be
==> Patching 16da5d4bb2d65a4d533d1da2a4e0d288d3a474c5
==> Patching 19724d34d2b223f940363cc07aa83a8a530f8093
==> Patching 1b6c9605e41b7c7dc23e0e6f633f05912d0463dd
==> Patching 1ccb50eaa670f86b69e7a64484a8c97e13169183
==> Patching 1d6d09fa6d3392343a89e1a4d116bf4170334300
==> Patching 1ed91951c3012e9aabb403d28b902c56cc143907
==> Patching 1f9036872d7ea8bee91f8588e3c4a613c58c76cb
==> Patching 210a2a2b9e5f7bc105897654bfea0f9cc7c8d89f
==> Patching 26f9949bf678abc1fae595e3f6eb59a5bf8a7564
==> Patching 27c3631d826aaad964f42ee94f26f9e80d658e3f
==> Patching 27ede55414e01f13c6869a8763da207e544cc6ad
==> Patching 3024c1434a667425d30e4b0785857381323712aa
==> Patching 31bec788f46c73ab14c72868dc6141141320a058
==> Patching 32820c149b4b92aafc5f8d2e48a4265c5d865a1d
==> Patching 3be2c3b3092e934bdc2db67d5bdcabd611deca9c
==> Patching 3c26ff450c914ab18e69b59777084eb101c65019
==> Patching 3c9e884dd3bf93b1516d3b5858072b7659c4cfba
==> Patching 3cb78259862d37da082f628af3ccb54edf264fd0
==> Patching 45d5a420ada9c11f61347fd4c63c7f0234adaea7
==> Patching 472ca7159812f8c360697f63454ee7bda1e02570
==> Patching 49ee9f3f08ba4583bc722a663e43551067ace271
==> Patching 4ab3bcb9ca137ad6e6ee4ae4a70a234d92b6d4ab
==> Patching 4bda94d0d820bf7baf2e97ec3552fe290b826391
==> Patching 4c8cddb11b34021434d8d757e174096b10475840
==> Patching 4f1e2357447ef7e8066c49560d66c3e18f25d982
==> Patching 5285d35b49e1e8976f2a8d9d2e6f5bd1324016d3
==> Patching 552eda70d33cead1398adfecce1a75e7a61e3daf
==> Patching 58557fafae060c500394d5df13cd0cf68170903e
==> Patching 5f62b2716fb3f11bcbe00bd32ca2ca2b9de94a11
==> Patching 62b19c627ebde2bbfa6021de146c502124da7975
==> Patching 62d6ba4638c0a4623f9aa703aa790da1380806d7
==> Patching 654c5788aa2130acfc89a0883952c6de4bddac95
==> Patching 67aaddddd6195f7283a94b472b2f14cbed9d95fc
==> Patching 6966f335ac7037900831007022f8d655bc186904
==> Patching 6edab01499c2af1b04e5914a64f0e66ae50253c3
==> Patching 71120ef1e5cb885ee45e6148970db6ce93ce1aca
==> Patching 72e8009185b537083015f43a8e0fd34509ab1938
==> Patching 78ab18199d69bcc801668bfbeea8190b2c73a939
==> Patching 7cbeddb7b78cc54a52d63ed8556da7121d1d2e68
==> Patching 7e7775ce7bfc916ce723bd1fdaf4ae54662c6627
==> Patching 80d733385aa2ff150a5d6f83ecfe55afc7e19e68
==> Patching 80e2e67f4c6fbbef5e4789df7fc96804e6a84196
==> Patching 8128817119e479b0610685e3fc7a6ff21cde5abc
==> Patching 837d6c70233715a0ae8e15c703d40e3046a2f36a
==> Patching 838a38365daa047fca7e57f63f9c54614c45595f
==> Patching 871bd237ee233bce3c3ba964c0b3948d685d7902
==> Patching 87aee45988e81cb1a7bc9881aa7172d4f9caefd4
==> Patching 8835289434ba88351610f1ca7a19f7fefe5a53fa
==> Patching 88badb98c74f764f6e4baea3f6c9d3fd16013023
==> Patching 8d06332a27b020f5252238946fa9dccc3843d52a
==> Patching 8e414e0e3f27d1917d11ee80de827698beb53891
==> Patching 8f10d6652ac212a7e30cb64017914ea1d5687767
==> Patching 8fba638b08eb85cda1bd2a4e855f7f76727dfc52
==> Patching 9128f6100c9bfe2c2c22d85ccec92f01166f5d25
==> Patching 92400cf8dcf411ce7e70ab2960639977d46d5b01
==> Patching 93969734f6a8f38e95c7038c926ab2504e87dad6
==> Patching 93ad4f2b9c093f204dbd5278c70256f6ec369b32
==> Patching 972d67cec1fc0aeafebcc60ffcdf4dea0eadff8c
==> Patching 98e3120ad218b8d9c50e25a525dcff689c515776
==> Patching 9a2c8783d91624261317316f996d8d2d09b7b6a4
==> Patching 9a5cef4de51c1c90fb2d05b0c7e6feb9cf0224d6
==> Patching 9b090a026108fab89cfe5f39bfd3492597e76ad4
==> Patching 9c854db82b767ddd228dbff1e51bb3eed87464b4
==> Patching 9f935c8dd891ec6eb0809b8438656d1b39c2e2f5
==> Patching 9fe3c065b0e94b1e2ce7f14ab512475e79426ce4
==> Patching a2d176e8f4774b84db22540a45eed7b29482f154
==> Patching af140ecdbc64251d7f536411c84e0d398a3d6631
==> Patching b20bba4f3777fd097539e1f516987e0d9729d710
==> Patching b4be4758361bf1b03410a523e8672b1c1fa7d385
==> Patching b5ed39ff10f0e46be6e97b577477e0f60234fa0b
==> Patching b60e6f82855d387c0ad98179c33e6c019e8a7d26
==> Patching b81da278623d9dcda1776008612bd42e1922e9c3
==> Patching b9adc3327ec7d2820ab2db8bb3cc2a0196a8375d
==> Patching bba7fd9dd54937719a6e88c954db7ab2ea5a3541
==> Patching c12a75742485dcc3db7b0f374e78f090c323830d
==> Patching c1fb50f5d377a41dd5833e4621e9a14879647503
==> Patching c9f99924192e5c3a8d120eb36bcf96419b3fc7e0
==> Patching cae91d7c8c21aa860bda29c62207a6726837952b
==> Patching cb56b2d1522e83c5bb0613abcf78b686e994df9e
==> Patching cc20ab1f2509de4ef0a9953e514d62fa23b6c572
==> Patching ce943eb369c9bdd0aef4917675e515f39f3b4a1e
==> Patching d280b40b18532dfeb80b1a98109fa6218630b939
==> Patching d2bc30b03fa4bf5425d080710f681f36f58f1706
==> Patching d301da55f8cd7b8b10771d3171ae60ba334bf067
==> Patching d311079a6f70577d02f35bb80d27eef7e2b18a4a
==> Patching d40c593f42fafbac1ff3d827f6df96338b5b7d8b
==> Patching d52acbe37f69a2ebc9d161c479ed628da1cbea4e
==> Patching d5c3becf00452fd1d35e695494d7ae41dedb11d8
==> Patching d6aa4e828c3dc3b7c417197990741b024f8c4ca3
==> Patching dcd80b80ae3fe2f327515e57fdc423a3927e44e6
==> Patching dd56a6ad0845b76509c4f8967e8ca476471ab7e0
==> Patching e107c8b84969fbe52cae7c9fd61858fddc6e016b
==> Patching e2554b36fc805c5dcb8bef65fee12e0753d5ad03
==> Patching e5277c1457d397f22ba18a1d40c1318729becbb4
==> Patching e593c3b89343a98bdcc76ce9f5869ff18882dfff
==> Patching e6cc4c5d13f8819c72568f9675e84c1d17368c67
==> Patching e7b0f2badf7c3393f1b36339b121054d05353442
==> Patching e9d70417cae7fcb08323351d9388b65b39560156
==> Patching ea505fd60b09bbfb127c874a27abac52d44bfe00
==> Patching eca11b99a7d25e4e6573472a16537c1aacb5d5e1
==> Patching ecbb896b9eb2acadefde57be493e4298c1aa04a3
==> Patching ee89c088b057affb5bdb96195e107a218b64b1c5
==> Patching f0a968eada509f71971e3ece02f8ec91b6f79e8a
==> Patching f1e191c0b959111aef19f3aa06b7f1743419470c
==> Patching f3ef077b910c9dada20eb106e8469ec071c27dad
==> Patching f5f74a22c94a7053d33c88d135f9fdc44fa2ea5b
==> Patching fc84f5f837a3e1b9b9bc992dd603d3d968502288
==> Patching fda473f00fa07b9a8246b104396f9922e54bff16
==> Patching ff457f012aef26f82c42c73783d7d3810d04d624
   Packaging core_io v0.1.20180307 (/home/nick/Documents/rust-core_io)
   Verifying core_io v0.1.20180307 (/home/nick/Documents/rust-core_io)
    Updating crates.io index
   Compiling semver v0.1.20
   Compiling rustc_version v0.1.7
   Compiling core_io v0.1.20180307 (/home/nick/Documents/rust-core_io/target/package/core_io-0.1.20180307)
error: failed to verify package tarball
Caused by:
  failed to run custom build command for `core_io v0.1.20180307 (/home/nick/Documents/rust-core_io/target/package/core_io-0.1.20180307)`
process didn't exit successfully: `/home/nick/Documents/rust-core_io/target/package/core_io-0.1.20180307/target/debug/build/core_io-53b44fc9f34e1c7b/build-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at 'Unknown compiler version, upgrade core_io?', src/libcore/option.rs:1034:5
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

This output is after I had already interactively applied the patches. But it seems like there aren't a year's worth of patches here, and I'm also a little confused as to why the commit hashes are in alphabetical order (I'd expect them to be listed chronologically?). I was wondering if you know what's going on with the failure in build.rs?

Some more background info:

Rustup version:

$ rustup show
...
active toolchain
----------------
nightly-x86_64-unknown-linux-gnu (default)
rustc 1.35.0-nightly (e782d790f 2019-03-29)

In my local Rust repository, I've pulled the latest master (befeeb7c083c9e5edddc86563cc461185d897a13), which I believe should include the nightly I'm aiming for in its history.

[jethrogb]

Sorry for not getting to this sooner, I hope to have a look at it this weekend.

[jethrogb]

But it seems like there aren't a year's worth of patches here,

This is fine, I think. You only need patches for changes to the libstd/io code, not for every single nightly.

and I'm also a little confused as to why the commit hashes are in alphabetical order

That's also confusing to me, not sure how that can happen. There's logic in build-src.sh to sort them chronologically...

[jethrogb]

and I'm also a little confused as to why the commit hashes are in alphabetical order

That's also confusing to me, not sure how that can happen. There's logic in build-src.sh to sort them chronologically...

Actually, the "old commits" (meaning commits with existing patches) are done chronologically, just to generate the source code. The "new commits" are ordered chronologically. So if you run build-src.sh twice, all commits are "old" and they'll all be in lexical order.

[jethrogb]

I was wondering if you know what's going on with the failure in build.rs?

This means that the compiler that is configured as the default does not have a patch prepared. Since you're using nightly, I'd guess that maybe you're using an outdated commit db?

[jethrogb]

Superceded by #18