When SIGINT is detected by devbox run send SIGTERM to the pid of the script that is running

[kadaan]

Summary

When SIGINT is detected by devbox run send SIGTERM to the pid of the script that is running. Fixes #1815

How was it tested?

I ran a script before this change and CTRL-C could not cancel it. With this change it can be canceled.

[kadaan]

Is there a good way to add test for these cases into the repository? If there is, I will gladly do it.

[mikeland73]

Instead of using the context to cancel, you can pass along kill signals. It's a bit more involved because you need to kill subprocesses as well.

You could do something like:

// This sets up a process group id.
// It is needed in order to kill a process group (will kill any subprocesses).
cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}

c := make(chan os.Signal, 1)
// Catch signals we may want to propagate. Not 100% sure about sigquit.
signal.Notify(c, syscall.SIGINT, syscall.SIGTERM, syscall.SIGQUIT)
defer func() {
	signal.Stop(c)
}()
go func() {
	select {
	case s := <-c:
		// note the negative pid. This means kill the group (process and children)
                // not sure what to do with error.
		_ = syscall.Kill(-cmd.Process.Pid, s.(syscall.Signal))
	case <-ctx.Done():
	}
}()

[mikeland73]

By default, the background context (which this is) is not canceled when sigint/sigterm are received. So I'm not sure this works. (in fact I think the background context is never canceled)

That said, passing context here is still an improvement (in case we do want to support cancel)

[kadaan]

I made an initial stab of doing it this way and cancelling didn't work. I will try to get back to this in a bit.