internal/devconfig: move project directory search into devbox.Find
#2172
+423
−272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of first searching for a project directory and then calling
devbox.Open
on that path, add adevbox.Find
method that performs the search and open as a single step.Find
a distinct function fromOpen
makes it clearer when we're recursively searching for a config vs. not.Find
can just try reading a potential config file path instead of performing a separateos.Stat
. This halves the number of system calls at startup and eliminates any potential races between the call toos.Stat
andos.Open
.Changes to user error messages: