FinOps on EKS #33
Open
FinOps on EKS #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maria-reynoso
requested review from
davidcollom,
BeckyPauley and
cyberbliss
as code owners
cyberbliss
reviewed
Nov 29, 2024
cyberbliss
previously approved these changes
Nov 29, 2024
jontutcher
reviewed
Dec 2, 2024
|
|
||
| ### Configuration changes for your cluster environment | ||
|
|
||
| 1. To control which Finops Stack components to install, edit the [enabled.yaml](./installation/config/common/enabled.yaml) file |
There was a problem hiding this comment.
For me, I just want a "default" set of things - coming to it fresh. Is what's enabled in the file in the repo a good starting point?
There was a problem hiding this comment.
Thats the intention, yes. everything in enabled.yaml should be defaulted on for a "default" set of things. enabled.yaml allows for people to toggle features on/off.
jontutcher
reviewed
Dec 2, 2024
jontutcher
reviewed
Dec 3, 2024
jontutcher
reviewed
Dec 23, 2024
davidcollom
reviewed
Jan 8, 2025
| @@ -1,3 +1,4 @@ | |||
| {{ if and .Values.dashboards }} | |||
There was a problem hiding this comment.
NIT:
Suggested change
| {{ if and .Values.dashboards }} | |
| {{ if .Values.dashboards }} |
and would only be needed if there were multiple conditions, there is only one defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.