Apply suggestions from code review

jetstack · Aug 15, 2024 · 712f2dc · 712f2dc
1 parent 07daed6
commit 712f2dc
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/pkg/metrics/metrics.go b/pkg/metrics/metrics.go
@@ -126,7 +126,7 @@ func (m *Metrics) RemoveImage(namespace, pod, container, containerType string) {
 	}
 
 	m.containerImageVersion.DeletePartialMatch(
-		m.buildPartialLabels(namespace, pod, container, item.image),
+		m.buildPartialLabels(namespace, pod),
 	)
 	delete(m.containerCache, index)
 }
@@ -151,8 +151,6 @@ func (m *Metrics) buildPartialLabels(namespace, pod, container, imageURL string)
 	return prometheus.Labels{
 		"namespace": namespace,
 		"pod":       pod,
-		"container": container,
-		"image":     imageURL,
 	}
 }