Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tolerations to helm for deployment #143

Merged
merged 9 commits into from
Feb 21, 2024
Merged

Add tolerations to helm for deployment #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9ff0304
feat(helm): add tolerations templating for deployemts
orangedrew Dec 13, 2023
67e7641
Merge pull request #1 from orangedrew/Add-tolerations--issue-#142
orangedrew Dec 13, 2023
9db314f
fix(helm): Empty default values tolerations
ladrsac Dec 13, 2023
2106f77
fix(helm): Empty default values tolerations.
ladrsac Dec 13, 2023
edf4ba7
Merge branch 'main' of github.com:orangedrew/version-checker
ladrsac Dec 13, 2023
5edab91
Merge branch 'main' into main
joshw123 Feb 21, 2024
7f41678
Merge branch 'main' into main
joshw123 Feb 21, 2024
c0a066f
Merge branch 'main' into main
joshw123 Feb 21, 2024
eb815e1
Merge branch 'main' into main
joshw123 Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions deploy/charts/version-checker/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ spec:
{{- end }}
spec:
serviceAccountName: {{ $chartname }}
{{- with .Values.tolerations }}
tolerations:
{{- toYaml . | trim | nindent 8 }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: not sure trim is actually needed here.

{{- end }}
containers:
- name: {{ $chartname }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
Expand Down
4 changes: 4 additions & 0 deletions deploy/charts/version-checker/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ image:
# -- Set the Image Pull Policy
pullPolicy: IfNotPresent

# -- Configure tolerations
tolerations: []

# -- Configure version-checkers Service
service:
labels: {}
Expand Down Expand Up @@ -97,6 +100,7 @@ selfhosted:
# password: bar
# token:


# -- Setup version-checkers resource requests/limits
resources:
{}
Expand Down
Loading