Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken pod metrics caching #160

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Fix broken pod metrics caching #160

merged 1 commit into from
Mar 7, 2024

Conversation

aidy
Copy link
Contributor

@aidy aidy commented Feb 27, 2024 •
edited
Loading

Add containerType to cache key, otherwise the cache data could be out of sync or non-existant and lead to stale entries in the prometheus gauge.

@aidy aidy requested a review from davidcollom as a code owner February 27, 2024 22:57
@aidy
Fix broken pod metrics caching
dd0879b 
Add containerType to cache key, otherwise the cache data could be out of
sync or non-existant and lead to stale entries in the prometheus gauge.
@aidy aidy force-pushed the fix_broken_pod_caching branch from b900d52 to dd0879b Compare February 27, 2024 23:06
@aidy
Copy link
Contributor Author

aidy commented Feb 28, 2024

Probably goes some way to addressing #69

davidcollom
davidcollom approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@davidcollom davidcollom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome, and yea.. not sure why I didn't think of this when implementing... I guess I was assuming that the init container image would be the same as the main (which isn't always the case of course)

@davidcollom davidcollom merged commit 895d12a into jetstack:main Mar 7, 2024
5 checks passed
@davidcollom davidcollom mentioned this pull request Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcollom davidcollom davidcollom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aidy @davidcollom