Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial delete metrics #203

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Partial delete metrics #203

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
07daed6
Partial delete metrics
davidcollom Jun 18, 2024
712f2dc
Apply suggestions from code review
davidcollom Aug 15, 2024
098efa5
Apply suggestions from code review
davidcollom Aug 15, 2024
a7e15a6
Merge branch 'main' into partial-delete-metrics
davidcollom Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions pkg/metrics/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,13 +120,13 @@
defer m.mu.Unlock()

index := m.latestImageIndex(namespace, pod, container, containerType)
item, ok := m.containerCache[index]

Check failure on line 123 in pkg/metrics/metrics.go

View workflow job for this annotation

GitHub Actions / Run unit tests for Go packages 

item declared and not used
if !ok {
return
}

m.containerImageVersion.Delete(
m.buildLabels(namespace, pod, container, containerType, item.image, item.currentVersion, item.latestVersion),
m.containerImageVersion.DeletePartialMatch(
m.buildPartialLabels(namespace, pod),
)
delete(m.containerCache, index)
}
Expand All @@ -147,6 +147,13 @@
}
}

func (m *Metrics) buildPartialLabels(namespace, pod string) prometheus.Labels {
return prometheus.Labels{
"namespace": namespace,
"pod": pod,
}
}

func (m *Metrics) Shutdown() error {
// If metrics server is not started than exit early
if m.Server == nil {
Expand Down
Loading