Fixed #12284 - Excessive heap consumption by SSLSessionImpl by Jetty Server with TLS 1.3 and long-lived client. #12288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Server with TLS 1.3 and long-lived client. Now `SslSessionData` is stored as a field, rather than in the `SSLSession` as an attribute. This implies a little more cost to create the `SslSessionData` per connection rather than per `SSLSession`, but it should be negligible. Now `SslSessionData` cannot be retrieved as a `SSLSession` attribute, but we have explicit APIs to retrieve it, so it should not be a problem. Signed-off-by: Simone Bordet <[email protected]>
joakime
changed the title
lorban
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
SslSessionDatais stored as a field, rather than in theSSLSessionas an attribute. This implies a little more cost to create theSslSessionDataper connection rather than perSSLSession, but it should be negligible.Now
SslSessionDatacannot be retrieved as aSSLSessionattribute, but we have explicit APIs to retrieve it, so it should not be a problem.