Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undisable WebAppContextTest.testGetResourcePaths #12502

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

janbartel
Copy link
Contributor

Undisable the ee9 WebAppContextTest.testGetResourcePaths test.

I discovered that in ee9 we have kept the call to URIUtil.canonicalizePath method in the ContextHandler.Context.getResource*() methods, however the meaning of this method changed in jetty-12: in older jetty versions it did the same as the new URIUtil.normalizePath method, but in jetty-12 it really does do the full canonicalization. I believe these ee9 methods need to use URIUtil.normalizePath methods instead. Worth noting that the ee10 ServletContextHander.ServletContextAPI methods do use URIUtil.normalizePath instead.

@janbartel janbartel requested a review from gregw November 8, 2024 00:21
@janbartel janbartel self-assigned this Nov 8, 2024
@janbartel janbartel mentioned this pull request Nov 8, 2024
38 tasks
@janbartel janbartel merged commit 7b5cf67 into jetty-12.1.x Nov 11, 2024
10 checks passed
@janbartel janbartel deleted the jetty-12.1.x-ee9-WebAppContextTest branch November 11, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants