Issue #13335 - fixes for HttpServletRequest.upgrade #13597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
|
@gregw can you please review this PR, currently only for EE11, but I can duplicate these changes for EE10 once we get the EE11 code reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13335
This PR prevents
HttpUpgradeHandler.initbeing called from within theHttpServletRequest.upgradeimplementation, this should only instantiate theHttpUpgradeHandler.see https://jakarta.ee/specifications/servlet/6.1/jakarta-servlet-spec-6.1#upgrade-processing
This PR also changes the
HttpServletRequest.upgradeimplementation to automatically set required headers for the upgrade.