Skip to content

Conversation

olamy
Copy link
Member

@olamy olamy commented Oct 3, 2025

Signed-off-by: Olivier Lamy [email protected]

@olamy olamy added the Build label Oct 3, 2025
@olamy olamy requested a review from joakime October 3, 2025 02:11
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets hold off on cleaning up the poms right now.
We can remove those sections later, once we've confirmed the new dependabot configs.

Besides, we can use that configuration as a reference when we implement the dependency exclusion behavior in dependabot too.

</plugins>
</build>
</profile>
</profiles>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets hold off on cleaning up the pom right now.
We can remove this section later, once we've confirmed the new dependabot configs.

</plugins>
</build>
</profile>
</profiles>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets hold off on cleaning up the pom right now.
We can remove this section later, once we've confirmed the new dependabot configs.

</plugins>
</build>
</profile>
</profiles>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets hold off on cleaning up the pom right now.
We can remove this section later, once we've confirmed the new dependabot configs.

</plugins>
</build>
</profile>
</profiles>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets hold off on cleaning up the pom right now.
We can remove this section later, once we've confirmed the new dependabot configs.

</plugins>
</build>
</profile>
</profiles>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets hold off on cleaning up the pom right now.
We can remove this section later, once we've confirmed the new dependabot configs.

@olamy
Copy link
Member Author

olamy commented Oct 6, 2025

Lets hold off on cleaning up the poms right now. We can remove those sections later, once we've confirmed the new dependabot configs.

Besides, we can use that configuration as a reference when we implement the dependency exclusion behavior in dependabot too.

I would say the opposite, if dependabot doesn't work we can simply revert the change and so the pom changes will be back and if it works, there's no need for another PR.
By experience, I can see that most of the time we never do the cleanup afterwards.
Just as I did when implementing using jakarta.platform:jakarta.jakartaee-bom for ee10 and ee11 and haven't done the cleaning :)

@olamy olamy force-pushed the fix/jetty-12.1.x/restore-dependabot-12-branches branch from 8c432d4 to f036068 Compare October 9, 2025 12:04
@olamy olamy requested a review from joakime October 9, 2025 12:06
@olamy
Copy link
Member Author

olamy commented Oct 9, 2025

if really needed, files will still be available, looking at the last tag https://github.com/jetty/jetty.project/tree/jetty-12.1.2
If not cleaned up now, it will never be done, and a few years later, we will ask, "Is this still needed or used?" :)

@olamy olamy force-pushed the fix/jetty-12.1.x/restore-dependabot-12-branches branch from f036068 to 61009d3 Compare October 13, 2025 21:39
@olamy olamy merged commit 10f0a69 into jetty-12.1.x Oct 14, 2025
10 checks passed
@olamy olamy deleted the fix/jetty-12.1.x/restore-dependabot-12-branches branch October 14, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants