add strict null check #8
Open
+257
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theBull
approved these changes
Feb 7, 2017
| @@ -4,10 +4,10 @@ import dateConverter from './common/dateconverter' | |||
|
|
|||
| class Student { | |||
| @JsonProperty('name') | |||
| fullName: string; | |||
| fullName?: string; | |||
There was a problem hiding this comment.
Why do these properties need to be made optional?
There was a problem hiding this comment.
As shown below, it's assigned with undefined, which could not pass the strict null checking:
|
Are there any plans for merging this PR in? |
|
@michael8090 are you able to merge? |
|
@theBull No, I've no write access |
|
@jf3096 would you be willing to merge this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.