Cayley/extend complex #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfalcou
reviewed
Oct 9, 2023
include/kyosu/functions/beta.hpp
Outdated
| @@ -61,12 +61,12 @@ namespace kyosu | |||
| //! | |||
| //! **Parameters** | |||
| //! | |||
| //! * `x`,`y` : Values to process. Can be a mix of complex and real floating values and complex values. | |||
| //! * `x`,`y` : Values to process. Can be a mix of cayley_dicson and real floating values. | |||
include/kyosu/functions/deta.hpp
Outdated
| @@ -56,8 +56,7 @@ namespace kyosu | |||
| //! @code | |||
| //! namespace kyosu | |||
| //! { | |||
| //! template<unsigned_scalar_value K, eve::ordered_value T> constexpr auto deta(K k, T z) noexcept; //1 | |||
| //! template<unsigned_scalar_value K, kyosu::concepts::complex T> constexpr auto deta(K k, T z) noexcept; //2 | |||
| //! constexpr auto deta(unsigned_scalar_value k, auto z) noexcept; | |||
There was a problem hiding this comment.
constexpr auto deta(unsigned_scalar_value àuto k, auto z) noexcept;` I guess ?
include/kyosu/functions/digamma.hpp
Outdated
| @@ -52,14 +52,13 @@ namespace kyosu | |||
| //! @code | |||
| //! namespace kyosu | |||
| //! { | |||
| //! template<kyosu::concepts::complex T> constexpr T digamma(T z) noexcept; | |||
| //! template<eve::floating_ordered_value T> constexpr T digamma(T z) noexcept; | |||
| //! constexpr auto digamma(T z) noexcept; | |||
include/kyosu/functions/erf.hpp
Outdated
| @@ -57,8 +57,7 @@ namespace kyosu | |||
| //! @code | |||
| //! namespace kyosu | |||
| //! { | |||
| //! template<eve::ordered_value T> constexpr auto erf(T z) noexcept; //1 | |||
| //! template<kyosu::concepts::complex T> constexpr auto erf(T z) noexcept; //2 | |||
| //! constexpr auto erf(auto z) noexcept; | |||
There was a problem hiding this comment.
Looks liek you mangled a bunch of those definitions, can you recheck the doc texts ?
include/kyosu/functions/zeta.hpp
Outdated
| @@ -56,8 +56,7 @@ namespace kyosu | |||
| //! @code | |||
| //! namespace kyosu | |||
| //! { | |||
| //! template<eve::floating_ordered_value T> constexpr auto zeta(T z) noexcept; | |||
| //! template<kyosu::concepts::complex T> constexpr auto zeta(T z) noexcept; | |||
| //! constexpr auto zeta(auto z) noexcept; | |||
There was a problem hiding this comment.
This is false, I don't think we can call zeta with a string ?
| //====================================================================================================================== | ||
| #pragma once | ||
|
|
||
| auto cayley_extend(auto f, auto z, auto... rs) |
There was a problem hiding this comment.
care to explain what if of them do ?
There was a problem hiding this comment.
pb with sincos etc.-> cayley_extend2
pb with deta(k,z) etc. -> cayley_extend_rev
cayley_extend works for all other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all complex function have now a proper cayley-dickson extension