-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cayley/extend complex #34
Conversation
include/kyosu/functions/beta.hpp
Outdated
@@ -61,12 +61,12 @@ namespace kyosu | |||
//! | |||
//! **Parameters** | |||
//! | |||
//! * `x`,`y` : Values to process. Can be a mix of complex and real floating values and complex values. | |||
//! * `x`,`y` : Values to process. Can be a mix of cayley_dicson and real floating values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cayley-dickson
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
include/kyosu/functions/deta.hpp
Outdated
@@ -56,8 +56,7 @@ namespace kyosu | |||
//! @code | |||
//! namespace kyosu | |||
//! { | |||
//! template<unsigned_scalar_value K, eve::ordered_value T> constexpr auto deta(K k, T z) noexcept; //1 | |||
//! template<unsigned_scalar_value K, kyosu::concepts::complex T> constexpr auto deta(K k, T z) noexcept; //2 | |||
//! constexpr auto deta(unsigned_scalar_value k, auto z) noexcept; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
constexpr auto deta(unsigned_scalar_value àuto k, auto z) noexcept;` I guess ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good guess
include/kyosu/functions/digamma.hpp
Outdated
@@ -52,14 +52,13 @@ namespace kyosu | |||
//! @code | |||
//! namespace kyosu | |||
//! { | |||
//! template<kyosu::concepts::complex T> constexpr T digamma(T z) noexcept; | |||
//! template<eve::floating_ordered_value T> constexpr T digamma(T z) noexcept; | |||
//! constexpr auto digamma(T z) noexcept; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is T ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto
include/kyosu/functions/erf.hpp
Outdated
@@ -57,8 +57,7 @@ namespace kyosu | |||
//! @code | |||
//! namespace kyosu | |||
//! { | |||
//! template<eve::ordered_value T> constexpr auto erf(T z) noexcept; //1 | |||
//! template<kyosu::concepts::complex T> constexpr auto erf(T z) noexcept; //2 | |||
//! constexpr auto erf(auto z) noexcept; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks liek you mangled a bunch of those definitions, can you recheck the doc texts ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
include/kyosu/functions/zeta.hpp
Outdated
@@ -56,8 +56,7 @@ namespace kyosu | |||
//! @code | |||
//! namespace kyosu | |||
//! { | |||
//! template<eve::floating_ordered_value T> constexpr auto zeta(T z) noexcept; | |||
//! template<kyosu::concepts::complex T> constexpr auto zeta(T z) noexcept; | |||
//! constexpr auto zeta(auto z) noexcept; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is false, I don't think we can call zeta with a string ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
//====================================================================================================================== | ||
#pragma once | ||
|
||
auto cayley_extend(auto f, auto z, auto... rs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
care to explain what if of them do ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pb with sincos etc.-> cayley_extend2
pb with deta(k,z) etc. -> cayley_extend_rev
cayley_extend works for all other
all complex function have now a proper cayley-dickson extension