Repository navigation
Conversation
jfhbrook
commented
Dec 13, 2025
jfhbrook
commented
Dec 21, 2025
jfhbrook
commented
Dec 21, 2025
jfhbrook
commented
Dec 21, 2025
jfhbrook
marked this pull request as ready for review
December 21, 2025 23:52
jfhbrook
commented
Dec 21, 2025
| } | ||
| `; | ||
|
|
||
| exports[`fixtures > 10 let i% = 0 |
Owner
Author
There was a problem hiding this comment.
This simple test script is broken. The bytecode is very straightforward, and looks correct. We'll need to trace it to understand what's going on.
| } | ||
| `; | ||
|
|
||
| exports[`fixtures > variable-increment.bas 1`] = ` |
Owner
Author
There was a problem hiding this comment.
This is the corresponding "failing" test. It currently passes because the snapshot shows a fault.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My working branch for implementing
onward. Also includes some new fixture-based tests!This code is probably correct enough to merge. But this work revealed that something about variable access and modification is busted. It's unrelated to the looping - a test confirms that - so I'm going to merge and fix in a future push. For now, onward is considered to be in mostly good shape.