Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake fixes #86

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CMake fixes #86

wants to merge 3 commits into from

Commits on Mar 23, 2019

  1. Fix CMake files for builds where project is built from outside directory 

    E.g: When it's added as 3rd library using ADD_SUBDIRECTORY CMake command
    @vizzerdrix
    vizzerdrix committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    359058f View commit details
    Browse the repository at this point in the history

  2. Replace all CMAKE_BINARY_PATH by PROJECT_BINARY_PATH 

    It prevents placing any project specific build artifacts in
common 'build' directory.
    @vizzerdrix
    vizzerdrix committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    5adf687 View commit details
    Browse the repository at this point in the history

  3. Remove link_directories call from CMakeLists.txt 

    To prevent placing any build artifacts in original source dir (breaking
shadow build idea)
    @vizzerdrix
    vizzerdrix committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    f674bdc View commit details
    Browse the repository at this point in the history