Bind point light counts #25
Conversation
|
@drawk-cab I need to do some more testing, but wouldn't mind a sanity check from you here. I'm fairly certain it fixes the example you provided, but never hurts to double check. |
jgayfer
force-pushed
the
point-light-count
branch
2 times, most recently
from
6c4f0a8 to
d431ee1
Compare
There was a problem hiding this comment.
Nice job! I hope you don't mind me checking this out, not sure what process you prefer when it comes to reviews so I just went for it. I found a tiny thing which tbh I'm not terribly sure how much time it would actually save, but I noticed that bevy uses len instead of count internally.
I tested this branch using the example provided in the issue: #18 but with 100 entities instead of one and all the lights correctly despawned (I double checked that running the example on main caused the lights not to despawn). So I think this is good to go.
jgayfer
force-pushed
the
point-light-count
branch
from
d431ee1 to
7622208
Compare
Once space is allocated in a buffer, it's allocated. Despawning a light doesn't clear the memory in the binding, unless we make a new binding. Prior to this change, despawning a light could have it hang around, still in memory. This change adds a separate binding to track the number of active point lights, and uses the number to iterate through the point light buffer, ensuring we won't over step.
jgayfer
force-pushed
the
point-light-count
branch
from
7622208 to
e66ad93
Compare
@isidornygren My strategy for reviews is usually to put up a PR and end up admin merging it 😅 I'm more than happy to have some feedback on changes. Please review as much as you'd like! A second pair of eyes is always helpful. Thanks for pitching in (especially for pulling it down for a quick test). |
Summary
Once space is allocated in a buffer, it's allocated. Despawning a light doesn't clear the memory in the binding, unless we make a new binding.
Prior to this change, despawning a light could have it hang around, still in memory.
This change adds a separate binding to track the number of active point lights, and uses the number to iterate through the point light buffer, ensuring we won't over step.
Fixes #18
Todo