Fix empty buffer size on WebGL2 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On WebGL2 we use a uniform binding that is 4096 bytes in size (due to the way GpuArrayBuffer) works. In order to not crash on WebGL2, we need to ensure the buffer is big enough to handle the values we're pretending are there.
|
Thanks for taking a look! Yeah #34 is a pretty big one. I want to sort that out soon. My hunch is it has something to do with how we set up the render graph, but I'm not entirely sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On WebGL2 we use a uniform binding that is 4096 bytes in size (due to the
way
GpuArrayBuffer) works.In order to not crash on WebGL2, we need to ensure the buffer is big enough
to handle the values we're pretending are there.
Fixes #35