Cache autoupdate check to run only once per 24 hours #2276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the update check ran on every application start, which was annoying when running drawio in scripts or frequently from CLI (even with --help flag). This change caches the last update check timestamp and only performs a new check if 24 hours have passed since the last one. Fixes jgraph#2262
src/main/electron.js
Outdated
|
|
||
| if (store == null || (!disableUpdate && !store.get('dontCheckUpdates'))) | ||
| // Cache update check - only check once per 24 hours to avoid repeated messages | ||
| const UPDATE_CHECK_INTERVAL = 24 * 60 * 60 * 1000; // 24 hours |
There was a problem hiding this comment.
Please make this UPDATE_CHECK_INTERVAL configurable. Hardcoding 24h looks like a kludge. What if I want to check once per week?
Allow users to configure the update check interval via 'updateCheckIntervalHours' setting in electron-store. Default remains 24 hours for backward compatibility. Example: Set to 168 for weekly checks.
murataslan1
force-pushed
the
fix/cache-autoupdate-check
branch
from
2badbe8 to
a7eb97c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR caches the autoupdate check so it only runs once per 24 hours instead of on every application start.
Problem
When running drawio frequently or in scripts (even with
--helpflag), the autoupdate check runs every time, outputting messages like:This is especially annoying when running drawio in a loop or automated scripts.
Solution
Changes
src/main/electron.jsto cache update check timestampFixes #2262