Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new fixes #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add new fixes #35

wants to merge 3 commits into from

Conversation

aharvet
Copy link

@aharvet aharvet commented Mar 1, 2021

  • Fix button element discrepencies from browser to browser
  • Remove Firefox red frame when input element is invalid
  • Fix version number in files

@aharvet
Add new fixes
e7f4218 
* Fix button element discrepencies from browser to browser
* Remove Firefox red frame when input element is invalid
* Fix version number in files
@nickdekruijk
Copy link

nickdekruijk commented Mar 1, 2021 •
edited
Loading

I think setting a font-size to 13px is way to specific. why not font: inherit as a whole? But then it should also apply to all input elements.

@aharvet
Copy link
Author

aharvet commented Mar 1, 2021 •
edited
Loading

The point with this is to normalize the font size from browser to browser and I chose Chrome's default value.

The problem with inherit is that the buttons are very likely to get disproportionate font sizes because it would inherit from regular text font size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aharvet @nickdekruijk