Add new option 'all' to output all matches #32
Conversation
This commit adds the option '--all' / '-a', which will cause fzy to ignore the selection and output all matching lines on return.
|
I've been using fzy for a day, it's really great! This feature is the only extra thing I really want from it. |
src/options.c
Outdated
| @@ -10,6 +10,7 @@ static const char *usage_str = | |||
| "" | |||
| "Usage: fzy [OPTION]...\n" | |||
| " -l, --lines=LINES Specify how many lines of results to show (default 10)\n" | |||
| " -a, --all Print all matched lines\n" | |||
There was a problem hiding this comment.
My mistake, vim inserted a tab and I didn't notice the other lines were spaces.
| printf("%s\n", state->search); | ||
| unsigned int all = state->options->output_all; | ||
| size_t start = all ? 0 : state->choices->selection; | ||
| size_t end = all ? choices_available(state->choices) : start + 1; |
There was a problem hiding this comment.
The rest of the code doesn't use whitespace to line up the = like that. Do you have an editor plugin that does it for you or do you have to do it manually? I'd be way too lazy for the latter :)
There was a problem hiding this comment.
I use the easyalign-plugin for vim. The above alignment would be done in 3 keystrokes (after selecting the region of interest).
There was a problem hiding this comment.
It sure is prettier, but I think it's bad. Say you add a fourth statement with a longer type and variable name, now you have to update 4 lines of code. If you just always use = then a single line of code won't involve changing others, keeping git diffs more readable. Yep, bad idea.
There was a problem hiding this comment.
Plus having to select code and run the macro is also too much hassle, for it to be worth it (ignoring the source control issues) it would have to automatically detect consecutive assignments and update them all without needing any user selection.
There was a problem hiding this comment.
Right. It's not important to me at all, I'd change that in a heart beat if it would stand in the way of the patch being accepted.
|
@jhawthorn would you be interested in this patch if it was cleaned up and submitted with a test? I'd really like to help get this feature delivered. |
|
In #40 I added an |
|
@lamarpavel I'm going to maintain a fork that accepts contributions from the community at https://github.com/ohjames/fzu until the maintainer here has time to engage with us. It already has the ability to select "all matches" and configurable key bindings. |
|
@ohjames Thank you for notifying me, and thanks to the AUR package I'm already using it. |
|
Cool if you need a flag to make "select all" the default I'll happily accept it :) For me selecting with a binding is best. |
|
That's all right, but maybe you should enable issues in your repo in case someone has comments to things not relevant for fzy (eg. you replaced one fzy -> fzu too many in the readme). |
This commit adds the option '--all' / '-a', which will cause fzy to
ignore the selection and output all matching lines on return.
I needed this feature so I could call fzy from vim and fill a location-list with the output. I just found fzy today and was pleasantly surprised by how clean the code base is and how easy it was to add new functionality, so I just wrote this small patch. There might be better ways to solve this, possibly without changing fzy. Feel free to reject this PR and point me in a different direction in that case.