bug fix

jhelvy · Feb 18, 2023 · 0592749 · 0592749
1 parent 41998ab
commit 0592749
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,7 @@
 # logitr (development version)
 
 - Added a startup message when the package is loaded
+- Fixed bug in adjustFactorLevels where the levels_orig object was being accidentally overwritten
 
 # logitr 1.0.0
 

diff --git a/R/predict.R b/R/predict.R
@@ -152,9 +152,9 @@ adjustFactorLevels <- function(object, newdata) {
     for (i in 1:length(factorLevels)) {
       par <- names(factorLevels)[[i]]
       levels_new <- factorLevels[[i]]
-      levels_orig <- levels_orig[[par]]
-      if (! identical(levels_new, levels_orig)) {
-        newdata[[par]] <- factor(newdata[[par]], levels = levels_orig)
+      levels_old <- levels_orig[[par]]
+      if (! identical(levels_new, levels_old)) {
+        newdata[[par]] <- factor(newdata[[par]], levels = levels_old)
       }
     }
   }