fixed bug in getCatVarDummyNames

jhelvy · Mar 18, 2021 · 58cb38a · 58cb38a
1 parent e454fb7
commit 58cb38a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -9,6 +9,7 @@
 ## Bugs
 
 - Fixed bug where model with single variable would error due to a matrix being converted to a vector in the `standardDraws()` function
+- Fixed bug in `getCatVarDummyNames()` - previously used string matching, which can accidentally match with other similarly-named variables.
 
 # logitr 0.1.1
 

diff --git a/R/modelInputs.R b/R/modelInputs.R
@@ -254,9 +254,9 @@ addIntPars <- function(data, parNames, intNames, parTypes) {
 }
 
 getCatVarDummyNames <- function(data, discPar) {
-  allVars <- names(data)
-  matches <- which(grepl(paste0(discPar, "_"), allVars))
-  return(allVars[matches][-1])
+  levels <- as.vector(as.matrix(unique(data[discPar])))
+  varNames <- sort(paste(discPar, levels, sep = "_"))
+  return(varNames[-1])
 }
 
 getParSetup <- function(parNames, priceName, randPars, randPrice) {