chore: Require servr >= 0.32 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids issues with favicon 404 responses blocking `to_pdf()`
|
Yeah this makes sense, it's a problem a lot of people are having. Maybe in making this we could also address the other errors to get it back on CRAN? I haven't looked at it in a long time. |
|
Oof I've looked at those failures before and they were a bit gnarly to untangle. It'd be nice to fix them and resubmit to CRAN! But I think we could still merge this change in case the fix takes a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids issues with favicon 404 responses blocking
to_pdf()and fixes #82.