Fix pdf printing on separate pages for A4 format #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for splitkbcompare ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks for fixing this! |
|
I just updated the app on shinyapps.io, this looks good to me now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printing the keyboards on separate pages is broken when using A4 format as noted in #78 and #98.
The reason is that when printing on separate pages was implemented in #64, it required a knitr workaround that was only added for letter format. This PR adds the same workaround now also for A4 format.
Closes #98