Skip to content

Conversation

LakshitAgarwal
Copy link

@LakshitAgarwal LakshitAgarwal commented Aug 4, 2025

attempt #29194

  • Renamed action from 'Deprecated: Generate' to 'Generate Application' with updated description.
  • Introduced new inputs for sample name and database type in the action configuration.
  • Replaced script-based generation steps with action-based steps for initializing the environment, generating sample configuration, and generating the project.
  • Added constants for sample generation, sample name, and database type in the generator.
  • Implemented logic to generate sample configurations and entities based on the selected database type in the generator class.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

- Renamed action from 'Deprecated: Generate' to 'Generate Application' with updated description.
- Introduced new inputs for sample name and database type in the action configuration.
- Replaced script-based generation steps with action-based steps for initializing the environment, generating sample configuration, and generating the project.
- Added constants for sample generation, sample name, and database type in the generator.
- Implemented logic to generate sample configurations and entities based on the selected database type in the generator class.

[ ] I have read the issue description and understand the requirements for dropping test-integration/scripts, moving samples to templates, and migrating workflows
@Tcharl
Copy link
Contributor

Tcharl commented Aug 11, 2025

I can't check this one (not enough knowledge): with my knowledge I can just verify that the overall CI did not change? @qmonmert @mshima ?

@mshima
Copy link
Member

mshima commented Aug 12, 2025

We do have shared actions in https://github.com/jhipster/actions and have jhipster github-build-matrix command.
In the issue we don't need to create new shared actions, but use those supported actions like in https://github.com/jhipster/generator-jhipster/blob/main/.github/workflows/angular.yml.

Make sure that those actions are used in:

Most of .github/actions should be dropped too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants