Skip to content
This repository was archived by the owner on Mar 21, 2021. It is now read-only.

Conversation

kevinbwusa
Copy link

@kevinbwusa kevinbwusa commented Feb 29, 2020

@pascalgrimaud
Copy link
Contributor

thanks for your PR !
I'll have a look soon, no worry for the failed builds, it's related to another issue

then, can you update your git config too ? as your config is related to JHipster Bot

@@ -0,0 +1,13 @@
export default function buildQueryParams(queryParams) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be cool to add test for this file

'core/ribbon/ribbon.vue',
'core/ribbon/ribbon.component.ts',
'shared/date/filters.ts',
'shared/query/params.ts',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following the other comment, needs to add params.spec.ts too

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ jhipster-bot
❌ Kevin Whittington


Kevin Whittington seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants