Add SRTM GL1 Ellipsoidal dataset from OpenTopography #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I am very open to accepting this PR, just need some time to dig through it. As I mentioned in #64 I am hoping to carve out some time for elevatr soon. |
I had added this for debugging, removing now that function is working so it doesn't cause the API key to be displayed in places it shouldn't be
|
Sounds great! No rush and no pressure to merge; I'm able to use this by installing from my fork. Thanks for making this super useful package! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case that requires the SRTM GL1 Ellipsoidal DEM from OpenTopography, so I added that as an option of
get_elev_rasterand dependencies. Specifically, it adds the option "gl1e" for thesrcparameter.This is my first PR to an R library. I don't know how to get the docs (
man) or any other dependencies to update automatically to match my updates to the functions underR. But the updated code runs the new functionality as expected.