Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for android notification #1198

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Conversation

geriby23
Copy link

We had an issue, where click on push notification in better player was not working, and app was not opened after click on notification. The reason for it was that we have flavors for the app(qa, uat, dev, prod) So package in our case has sufixes.
Also another issue why it was not working in our app, was because we have different packages in src folder and gradle file. It's because project previously was written on android and than it was changed to flutter. So we had to have old package to be able to replace old project.
So in this fork, I have added packageName field to the NotificationsConfig.
So for example:

notificationConfiguration: BetterPlayerNotificationConfiguration(
showNotification: true,
title: widget.title,
imageUrl: widget.logoUrl,
packageName: locator().packageName, <-- here we will specify what package we have currently, for example: com.something.qa or com.something.uat
activityName: "io.example.something.MainActivity", <- so now we should place full path to the mainActivity file.
),

  I think it would be more flexible for users to specify packages they need.
  
  Also we have spotted a crash in  method_channel_video_player.dart in MethodChannelVideoPlayer.getAbsolutePosition at line 222:21 within better_player
  For live stream it was throwing sometimes exception:
  RangeError (millisecondsSinceEpoch): Invalid value: Not in inclusive range -8640000000000000..8640000000000000: 9223372036854774434
  
  This was handled as well in this fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant