-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for android notification #1198
Open
geriby23
wants to merge
32
commits into
jhomlala:master
Choose a base branch
from
geriby23:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…: Not in inclusive range -8640000000000000..8640000000000000: 9223372036854775393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue, where click on push notification in better player was not working, and app was not opened after click on notification. The reason for it was that we have flavors for the app(qa, uat, dev, prod) So package in our case has sufixes.
Also another issue why it was not working in our app, was because we have different packages in src folder and gradle file. It's because project previously was written on android and than it was changed to flutter. So we had to have old package to be able to replace old project.
So in this fork, I have added packageName field to the NotificationsConfig.
So for example:
notificationConfiguration: BetterPlayerNotificationConfiguration(
showNotification: true,
title: widget.title,
imageUrl: widget.logoUrl,
packageName: locator().packageName, <-- here we will specify what package we have currently, for example: com.something.qa or com.something.uat
activityName: "io.example.something.MainActivity", <- so now we should place full path to the mainActivity file.
),