Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing test warnings #744

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixing test warnings #744

wants to merge 3 commits into from

Conversation

lumip
Copy link

@lumip lumip commented Jul 23, 2023

This fixes some errors and a number of warnings I got when running the tests:

  • Some tests fail with ffmpeg error "Unknown encoder 'libvorbis'" - added skip condition if libvorbis is not a known encoder
  • Many warnings about unclosed file handles - fixed in the tests and in relevant AudioSegment functions
  • Deprecation warnings about assertEquals (should be assertEqual)

@lumip
Tests no longer using assertEquals
2b73900
@lumip
Skipping relevant tests if libvorbis is not a supported codec
69f7ff7
@lumip
Ensuring that files are always closed
596c2ec 
- AudioSegment.from_file would previously not close all opened files in
  case of raised exceptions.
- Some tests would not close obtained open file handles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lumip