Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved detect silence #745

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Jul 23, 2023

  1. Adding specific tests for detect_silence.

    detect_silence finds separate slices of silence and in a last step
    combines subsequent silent slices into ranges of continuous silence.
    The added tests specifically ensure the correct function of this
    combination step.
    lumip committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    eef2e46 View commit details
    Browse the repository at this point in the history
  2. detect_silence combines continuous silent ranges on-the-fly

    Previously, detect_silence would collect all slices of min_silence_len
    in a list, then processed that list to merge subsequent slices
    into continuous silent ranges.
    This change performs the merging immediately when silence is detected
    for a slice, eliminating the need for a second pass over and the memory
    overhead associated with the internal list of silent slices.
    lumip committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    6c789c9 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Significant runtime improvements to detect_silence

    Using numpy to compute RMS for silence detection to reduce
    redundant computation (and benefit from numpys highly optimized
    implementation) compared to previous implementation of
    detect_silence.
    
    Some caveats:
    - adds numpy as new dependency
    - previously RMS values where rounded down to the next integer;
      this is now not the case anymore, resulting in borders of silence
      ranges to possibly vary slightly compared to previous implementation
    lumip committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    61a9459 View commit details
    Browse the repository at this point in the history