Open
Conversation
|
Hey @kristinn93, TravisBuddy Request Identifier: 07013380-65c6-11e9-aafa-87f824428b00 |
|
This probably affects (and hopefully resolves?) #31. |
jimexist
approved these changes
Apr 23, 2019
Contributor
Author
|
@mlms13 Yes this will solve that. I had the same issue. By doing this Js.log2("moment", MomentRe.momentNow());The following code is generated: import * as Moment from "moment";
console.log("moment", Moment()); |
Contributor
Author
|
Also if you were wondering it's not possible to use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently I'm maintaining my own fork of these bindings since I use es6 in all of my projects.
A lot of the changes are refmt changes, but in line 312 I added a
ES6module.This is backwards compatible and won't affect anyone.
This allows people who have es6 setup to instantiate a Moment object like this:
because
crashes my bundler