Add a configurable multiplication factor in Exponential delay#30
Merged
jimmycuadra merged 1 commit intojimmycuadra:masterfrom Aug 15, 2020
Merged
Conversation
PatrickLerner
force-pushed
the
add_first_in_millis_to_exponential
branch
from
70b37ca to
2c156fd
Compare
Owner
|
Thanks! Released in https://github.com/jimmycuadra/retry/releases/tag/1.1.0. |
Contributor
Author
|
Thank you @jimmycuadra! I appreciate it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #23 and adds a new constructor to Exponential delays that allows specifying the factor of multiplication instead of using the base as the factor. In particular for retrying API responses it is desirable to use a lesser factor as otherwise the time to wait increases far too quickly to be useable.
I added two allows for deprecation because Rust recently deprecated some method (ref: rust-lang/rust#66919). Please advise if you would like to see this handled differently. I suppose for early rust version support they might still be required, so I did not want to remove them completely.