Skip to content

Show model info for each DAC in DAC view - #21

Merged
heymrbox merged 1 commit into
mainfrom
weiwei-dev
Apr 3, 2026
Merged

Show model info for each DAC in DAC view#21
heymrbox merged 1 commit into
mainfrom
weiwei-dev

Conversation

@heymrbox

@heymrbox heymrbox commented Apr 3, 2026

Copy link
Copy Markdown
Collaborator
  • Extended DAC table rows to include each cluster’s ModelName, so the list and CSV export now surface the associated model (internal/ui/tui/row_builders.go:191).

    • Added a dedicated “Model” column to the DAC table headers and rebalanced the column ratios to fit the new field cleanly (internal/ui/tui/headers.go:128).
    • Updated the DAC row builder test fixture to exercise and assert the new model column (internal/ui/tui/row_builders_test.go:205).
  • All new and changed code is covered by tests.

  • Tests use t.Parallel() where possible.

  • Lint and static analysis pass (make lint).

  • Code is formatted with gofumpt -w ..

  • Code coverage is at least 80% (make cover-check).

  • Benchmarks are added for performance-critical code.

  • Golden files and fuzz corpora are updated as needed.

Screenshot 2026-04-03 at 4 15 22 PM

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@heymrbox
heymrbox requested a review from jingle2008 April 3, 2026 23:27
@heymrbox
heymrbox merged commit 6954790 into main Apr 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants