Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

优化 #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

优化 #29

wants to merge 2 commits into from

Conversation

xxnuo
Copy link
Contributor

@xxnuo xxnuo commented Dec 4, 2024

还有一些优化,先 pr 放着,你觉得不合适的或者没搞定的可以告诉我来改一改

@jingsongliujing
Copy link
Owner

感觉多个os.getenv略显繁琐了一些,我觉得还是Path(file).resolve().parent 可读性要好一些

@xxnuo
Copy link
Contributor Author

xxnuo commented Dec 18, 2024

考虑过发布成 pypi 包吗

@jingsongliujing
Copy link
Owner

jingsongliujing commented Dec 18, 2024 via email

@ILG2021
Copy link

ILG2021 commented Dec 20, 2024

有考虑过,不过目前还没有太稳定的版本,特别是模型放置方法,大佬有啥建议么
hugginface 或者 github raw可以吗?

@jingsongliujing
Copy link
Owner

有考虑过,不过目前还没有太稳定的版本,特别是模型放置方法,大佬有啥建议么
hugginface 或者 github raw可以吗?

这是一个好的建议,后续会考虑上一个pip包

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants