fix(tui): pin platform default driver — TG 2.4.17 auto-detect picks the keypress-dropping ansi driver#51
Merged
Merged
Conversation
…ks the keypress-dropping ansi driver Terminal.Gui 2.4.17 added an 'ansi' driver and its auto-detect now selects it on a bare terminal (IDriver.GetName() confirms), superseding 2.4.16's 'windows' default. The ansi driver's input path drops every other keypress: vim j/k moves once per two presses (input eaten — the second press moves one row — in both lists, persistently). Reproduces on main under COBALT_DRIVER=ansi; windows and dotnet are clean. ResolveDriver now pins the pre-2.4.17 platform default explicitly (windows on Windows, dotnet elsewhere) instead of falling through to TG auto-detect; the multiplexer/RDP path degrades to the same pin if 'dotnet' is ever unregistered. null (TG picks) remains only when even the pinned driver is missing. COBALT_DRIVER still overrides everything, including =ansi. Also records in ADR 0016 that INPUT-1's owed both-driver UAT passed 2026-07-22 (the double-press seen at that UAT was this ansi driver, initially misattributed to INPUT-1).
jinyeow
added a commit
that referenced
this pull request
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Terminal.Gui 2.4.17's auto-detect selects its new
ansidriver on a bare terminal, and that driver's input path drops every other keypress — vimj/kmoves once per two presses. Every plain-terminal user of currentmainhas this since the 2.4.16→2.4.17 bump (#8).ResolveDrivernow pins the pre-2.4.17 platform default explicitly (windowson Windows,dotnetelsewhere) and never falls through to TG auto-detect.COBALT_DRIVERstill overrides everything, including=ansito retest the upstream bug.Diagnosis (UAT, herdr on Windows Terminal, 2026-07-22)
ansi)ansiexplicitmain)windowsexplicitdotnetexplicitSecond press moves 1 row (input eaten, not repaint lag), both lists, persistent. Ruled out on the way: INPUT-1's targeted redraw (#18) and the
:logobserver marshalling (#35) — both exonerated by kill-switch probes.Changes
ResolveDriver:isWindowsseam; platform pin replaces thenullfall-through; multiplexer/RDP path degrades to the pin (never TG auto) ifdotnetis unregistered;nullonly when even the pinned driver is missing.ansisince 2.4.17; supersedes the "TG pickswindows" claims) + records INPUT-1's owed both-driver UAT as passed (the double-press at that UAT was this driver, initially misattributed).