feat(nvim): swap diffview.nvim for the maintained diffview-plus fork - #48
Merged
Conversation
sindrets/diffview.nvim has had no commits since 2024-06-13 and carries 130 open issues; the PR-review workflow (<leader>gm, ado-pr.nvim, review-ado-pr) depends on it. dlyongemallo/diffview-plus.nvim is the active fork and keeps the `diffview` module namespace plus the :Diffview* commands, so config/diffview.lua and its keymaps are unchanged. The existing opts need no migration: the fork's documented breaking changes cover file_panel.show (not set), flat log options (not set), and win_config nesting (already nested). The old lockfile key is removed rather than left beside the new one - the offline plugin installer provisions every lockfile entry, so a stale key would put a second lua/diffview/ on the packpath on offline machines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sindrets/diffview.nvim has had no commits since 2024-06-13 and carries 130
open issues; the PR-review workflow (gm, ado-pr.nvim, review-ado-pr)
depends on it. dlyongemallo/diffview-plus.nvim is the active fork and keeps
the
diffviewmodule namespace plus the :Diffview* commands, soconfig/diffview.lua and its keymaps are unchanged.
The existing opts need no migration: the fork's documented breaking changes
cover file_panel.show (not set), flat log options (not set), and win_config
nesting (already nested).
The old lockfile key is removed rather than left beside the new one - the
offline plugin installer provisions every lockfile entry, so a stale key
would put a second lua/diffview/ on the packpath on offline machines.