Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DefaultSourceFlags option #161

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

ekulabuhov
Copy link

Hey Jinzhu! Nice work on the library! I was looking for a way to copy all fields from one nested structure to another while also warning me if any fields are missing in the destination structure. Adding copier tags across many fields would add too much noise. So, I've decided to add a "default flag" option to copier itself. Thought you might find it useful too.

@uded
Copy link
Collaborator

uded commented Jan 6, 2023

HI @ekulabuhov,

I am not willing to merge this, although it seems like a nice feature, as your branch seems separate too much from the base. This can't be accepted if you change the package name and some other details. If you would be willing to clean it up, I am happy to get the ball running on this.

@jinzhu
Copy link
Owner

jinzhu commented Jan 10, 2023

Seems tests failed and import path was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants