Code static analysis

NO-JIRA: fix(gha): replace oc with kubectl in notebook_controller_int… #177

Sign in to view logs

Triggered via push October 15, 2024 15:14

jiridanek

oc_kubectl

Status Failure

Total duration 1m 40s

Artifacts –

code-quality.yaml

on: push

Matrix: golangci-lint

Matrix: govulncheck

Annotations

20 errors

golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_controller.go#L116

Error return value of `retry.OnError` is not checked (errcheck)

golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_oauth.go#L193

Error return value of `rand.Read` is not checked (errcheck)

golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/suite_test.go#L58

var `cfg` is unused (unused)

golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/suite_test.go#L67

const `timeout` is unused (unused)

golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/suite_test.go#L68

const `interval` is unused (unused)

golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/e2e/notebook_creation_test.go#L142

SA4009: argument err is overwritten before first use (staticcheck)

golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/e2e/notebook_creation_test.go#L144

SA4009(related information): assignment to err (staticcheck)

golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_route.go#L47

SA1019: pointer.Int32Ptr is deprecated: Use ptr.To instead. (staticcheck)

golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_webhook.go#L187

SA1019: pointer.Int32Ptr is deprecated: Use ptr.To instead. (staticcheck)

golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_webhook.go#L210

SA1019: pointer.Int32Ptr is deprecated: Use ptr.To instead. (staticcheck)

golangci-lint (components/notebook-controller): components/notebook-controller/controllers/culling_controller_test.go#L256

Error return value is not checked (errcheck)

golangci-lint (components/notebook-controller): components/notebook-controller/api/v1beta1/notebook_webhook.go#L24

var `notebooklog` is unused (unused)

golangci-lint (components/notebook-controller): components/notebook-controller/controllers/suite_test.go#L43

var `cfg` is unused (unused)

golangci-lint (components/notebook-controller): components/notebook-controller/controllers/notebook_controller_bdd_test.go#L65

S1008: should use 'return err == nil' instead of 'if err != nil { return false }; return true' (gosimple)

golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L325

S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/pkg/culler.KernelStatus is defined as zero (gosimple)

golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L362

S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/pkg/culler.TerminalStatus is defined as zero (gosimple)

golangci-lint (components/notebook-controller): components/notebook-controller/controllers/culling_controller.go#L359

S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/controllers.KernelStatus is defined as zero (gosimple)

golangci-lint (components/notebook-controller): components/notebook-controller/controllers/culling_controller.go#L395

S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/controllers.TerminalStatus is defined as zero (gosimple)

golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L137

S1033: unnecessary guard around call to delete (gosimple)

golangci-lint (components/notebook-controller): components/notebook-controller/controllers/notebook_controller.go#L96

S1021: should merge variable declaration with assignment on next line (gosimple)