Add golang-ci and other linters #1
Annotations
21 errors
|
|
|
components/notebook-controller/controllers/culling_controller_test.go#L256
Error return value is not checked (errcheck)
|
|
components/notebook-controller/api/v1beta1/notebook_webhook.go#L24
var `notebooklog` is unused (unused)
|
|
components/notebook-controller/controllers/suite_test.go#L43
var `cfg` is unused (unused)
|
|
components/notebook-controller/controllers/notebook_controller_bdd_test.go#L65
S1008: should use 'return err == nil' instead of 'if err != nil { return false }; return true' (gosimple)
|
|
components/notebook-controller/controllers/notebook_controller.go#L96
S1021: should merge variable declaration with assignment on next line (gosimple)
|
|
components/notebook-controller/pkg/culler/culler.go#L325
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/pkg/culler.KernelStatus is defined as zero (gosimple)
|
|
components/notebook-controller/pkg/culler/culler.go#L362
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/pkg/culler.TerminalStatus is defined as zero (gosimple)
|
|
components/notebook-controller/controllers/culling_controller.go#L359
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/controllers.KernelStatus is defined as zero (gosimple)
|
|
components/notebook-controller/controllers/culling_controller.go#L395
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/controllers.TerminalStatus is defined as zero (gosimple)
|
|
components/notebook-controller/pkg/culler/culler.go#L137
S1033: unnecessary guard around call to delete (gosimple)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This job failed
Loading