Add golang-ci and other linters #6
Annotations
20 errors
|
components/notebook-controller/pkg/culler/culler.go#L325
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/pkg/culler.KernelStatus is defined as zero (gosimple)
|
|
components/notebook-controller/pkg/culler/culler.go#L362
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/pkg/culler.TerminalStatus is defined as zero (gosimple)
|
|
components/notebook-controller/pkg/culler/culler.go#L137
S1033: unnecessary guard around call to delete (gosimple)
|
|
components/notebook-controller/pkg/culler/culler.go#L346
S1039: unnecessary use of fmt.Sprintf (gosimple)
|
|
components/notebook-controller/pkg/culler/culler.go#L373
S1039: unnecessary use of fmt.Sprintf (gosimple)
|
|
components/notebook-controller/pkg/culler/culler.go#L266
SA5011: possible nil pointer dereference (staticcheck)
|
|
components/notebook-controller/pkg/culler/culler.go#L267
SA5011(related information): this check suggests that the pointer can be nil (staticcheck)
|
|
components/notebook-controller/controllers/culling_controller_test.go#L256
Error return value is not checked (errcheck)
|
|
components/notebook-controller/controllers/suite_test.go#L43
var `cfg` is unused (unused)
|
|
components/notebook-controller/controllers/notebook_controller_bdd_test.go#L65
S1008: should use 'return err == nil' instead of 'if err != nil { return false }; return true' (gosimple)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This job failed
Loading