Skip to content

Commit

Permalink
fixup, go mod tidy -diff not yet implemented
Browse files Browse the repository at this point in the history
  • Loading branch information
jiridanek committed Jun 14, 2024
1 parent 542117b commit fed96fd
Showing 1 changed file with 23 additions and 5 deletions.
28 changes: 23 additions & 5 deletions .github/workflows/code-quality.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,18 @@ jobs:
if: "${{ !cancelled() }}"
working-directory: components/notebook-controller

- run: go mod tidy --diff
if: "${{ !cancelled() }}"
working-directory: components/notebook-controller

# https://github.com/golang/go/issues/27005
- run: |
set -e
go mod tidy
if [[ $(git ls-files . -d -m -o --exclude-standard --full-name -v | tee modified.log | wc -l) -gt 0 ]]; then
echo "There are changed files:"
cat modified.log
git diff
exit 1
fi
# https://go.googlesource.com/vuln
# https://github.com/golangci/golangci-lint/issues/3094
- run: |
go install golang.org/x/vuln/cmd/govulncheck@latest
Expand Down Expand Up @@ -72,10 +80,20 @@ jobs:
if: "${{ !cancelled() }}"
working-directory: components/odh-notebook-controller

- run: go mod tidy --diff
# https://github.com/golang/go/issues/27005
- run: |
set -e
go mod tidy
if [[ $(git ls-files . -d -m -o --exclude-standard --full-name -v | tee modified.log | wc -l) -gt 0 ]]; then
echo "There are changed files:"
cat modified.log
git diff
exit 1
fi
if: "${{ !cancelled() }}"
working-directory: components/odh-notebook-controller
# https://go.googlesource.com/vuln
# https://github.com/golangci/golangci-lint/issues/3094
- run: |
go install golang.org/x/vuln/cmd/govulncheck@latest
Expand Down

0 comments on commit fed96fd

Please sign in to comment.