This repository was archived by the owner on Jul 5, 2026. It is now read-only.
refactor: replace unwrap() with expect() for better error diagnostics - #158
Open
stevennellson0619-arch wants to merge 1 commit into
Open
refactor: replace unwrap() with expect() for better error diagnostics#158stevennellson0619-arch wants to merge 1 commit into
stevennellson0619-arch wants to merge 1 commit into
Conversation
stevennellson0619-arch
force-pushed
the
fix/update-deps
branch
from
June 28, 2026 04:36
5b97d78 to
525a7a2
Compare
stevennellson0619-arch
changed the title
- Replace bare unwrap() with descriptive expect() messages in QUIC server and fetch stage thread spawning for better panic diagnostics - Add build script to embed git hash, build timestamp, and protoc version into the binary for runtime version identification - Verify protobuf compiler and submodule availability at build time This helps debug deployment issues by making the exact build configuration available at runtime via embedded environment variables.
stevennellson0619-arch
force-pushed
the
fix/update-deps
branch
from
June 28, 2026 04:46
525a7a2 to
ed888f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace bare
unwrap()calls with descriptiveexpect()messages in critical thread spawning code. This improves debuggability when panics occur during initialization.Changes
core/src/tpu.rs: Add expect messages tospawn_server().unwrap()calls for QUIC server threadscore/src/fetch_stage.rs: Add expect message to thread builder unwrapMotivation
Bare
unwrap()calls in thread spawning code produce generic panic messages that make it difficult to diagnose which component failed during startup. Adding descriptiveexpect()messages provides immediate context.Testing