chore: cleanup syntax #86
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrenix
force-pushed
the
chore/cleanup
branch
2 times, most recently
from
7cebd4c to
e71c94b
Compare
- replace range with toYaml - replace if with with - use quote filter on password (it could contains an ' or ") - remove strange tpl and trim - use default filter - nicer indent - remove invalid checks (if something invalid, the chart install should failed)
|
Hello @wrenix! The PR needs a rebase now. Also, can you please return the Also, please take a look at the review comments I left earlier. :) |
|
Wow you really has such dirty things in your |
|
I was thinking about actually pulling the |
|
Hello @wrenix! I introduced a bunch of new commits over the course of past few weeks and now I'm slowing down, getting ready for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #84 , #87